Make WriteBufferReader functions exception safe
#532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
force-pushed
the
jdral/fault-test-writebufferreader
branch
from
3206531 to
fcbc71e
Compare
jorisdral
requested review from
dcoutts,
mheinzel,
recursion-ninja and
wenkokke
as code owners
|
I'll put this PR in draft mode again, because we probably need to merge #529 first |
jorisdral
force-pushed
the
jdral/fault-test-writebufferreader
branch
from
b1735ac to
e8dfda6
Compare
jorisdral
force-pushed
the
jdral/fault-test-writebufferblobs
branch
from
4e41423 to
bccc25d
Compare
jorisdral
force-pushed
the
jdral/fault-test-writebufferreader
branch
from
e8dfda6 to
da65614
Compare
|
Ready for review now |
jorisdral
force-pushed
the
jdral/fault-test-writebufferreader
branch
from
da65614 to
8df7111
Compare
wenkokke
force-pushed
the
jdral/fault-test-writebufferreader
branch
from
8df7111 to
7e962d2
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #521