Fix out-of-bounds array access in hFlipBit.
#551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
requested review from
dcoutts,
mheinzel,
recursion-ninja and
wenkokke
as code owners
mheinzel
reviewed
Jan 28, 2025
We were not calculating the maximum bit offset correctly, so we were not generating bit offsets towards the end of the byte string.
A use of `setByteArray`was writing outside of the byte array bounds. This is now fixed.
jorisdral
force-pushed
the
jdral/issue-549
branch
from
e06c0fb to
02e7aa7
Compare
|
I've turned on auto-merge, so once this is approved it should move into the merge queue automatically |
wenkokke
approved these changes
Jan 28, 2025
mheinzel
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #549