Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When hard fork happens, check that transition point matches lower bound in EraParams #2386

Closed
edsko opened this issue Jul 10, 2020 · 0 comments
Assignees
Labels
consensus issues related to ouroboros-consensus transition

Comments

@edsko
Copy link
Contributor

edsko commented Jul 10, 2020

If it doesn't match, the node is configured incorrectly, and will almost certainly not operate correctly. We can detect it the moment that the transition becomes known; this then gives us a stability window (12 hours for Byron) to detect the problem, so we should trace this with "critical" severity and then hope that devops see it and fix the problem before the hard fork happens.

If the problem persists at the hard fork, I'm not entirely sure what to do. Shutting down would be the safest -- having this value be wrong could have unforeseen consequences in lots of places...?

Marking this as medium priority because it's not critical for a release, but it will avoid some confusion in the tests so assigned it to the current milestone.

@edsko edsko added consensus issues related to ouroboros-consensus transition priority medium labels Jul 10, 2020
@edsko edsko added this to the S17 2020-07-16 milestone Jul 10, 2020
@edsko edsko self-assigned this Jul 10, 2020
edsko added a commit that referenced this issue Jul 13, 2020
edsko added a commit that referenced this issue Jul 13, 2020
@iohk-bors iohk-bors bot closed this as completed in ad77e90 Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus issues related to ouroboros-consensus transition
Projects
None yet
Development

No branches or pull requests

1 participant