Avoid recomputing the ShelleyLedgerConfig #2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #2375, we discovered that validating a Byron chain took 10x as long using `CardanoBlock` than using `ByronBlock`. Looking at the profiling report, we see it being dominated by: ``` exp' src/Shelley/Spec/NonIntegral.hs:(171,1)-(175,43) 52.1 56.7 ln' src/Shelley/Spec/NonIntegral.hs:(159,1)-(162,27) 22.7 26.1 ``` Which is strange, as we're validating a Byron-only chain! It turns out that these two functions are called by `mkActiveSlotCoeff`, which is called as part of `mkShelleyLedgerConfig`, which we are calling in `completeLedgerConfig`. This happens for *each* block. To fix this, we replace the partial ledger config of Shelley with a non-partial one containing a dummy `EpochInfo Identity`. In `completeLedgerConfig` we replace the dummy `EpochInfo Identity` with the correct one. This means we only call `mkShelleyLedgerConfig` once and cache its result.
mrBliss
force-pushed
the
mrBliss/cache-ledgerconfig
branch
from
372d4a1 to
28f451e
Compare
edsko
approved these changes
Jul 13, 2020
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2375, we discovered that validating a Byron chain took 10x as long using
CardanoBlockthan usingByronBlock.Looking at the profiling report, we see it being dominated by:
Which is strange, as we're validating a Byron-only chain! It turns out that
these two functions are called by
mkActiveSlotCoeff, which is called as partof
mkShelleyLedgerConfig, which we are calling incompleteLedgerConfig. Thishappens for each block.
To fix this, we replace the partial ledger config of Shelley with a non-partial
one containing a dummy
EpochInfo Identity. IncompleteLedgerConfigwereplace the dummy
EpochInfo Identitywith the correct one. This means we onlycall
mkShelleyLedgerConfigonce and cache its result.