Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chocolatey error in GH Actions Windows CI #3896

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Fix chocolatey error in GH Actions Windows CI #3896

merged 1 commit into from
Jul 13, 2022

Conversation

amesgen
Copy link
Member

@amesgen amesgen commented Jul 13, 2022

Description

Like #3075, in order to fix the current CI issue, see e.g. #3891 (comment)

Checklist

  • Branch
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • New tests are added if needed and existing tests are updated
    • If this branch changes Consensus and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
    • If this branch changes Network and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@amesgen amesgen requested review from coot, newhoggy and a team as code owners July 13, 2022 12:59
@amesgen
Copy link
Member Author

amesgen commented Jul 13, 2022

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 13, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 53edc88 into master Jul 13, 2022
@iohk-bors iohk-bors bot deleted the amesgen/chocolatey-fix branch July 13, 2022 19:50
nfrisby pushed a commit that referenced this pull request Jul 21, 2022
@iohk-bors @amesgen @nfrisby
Merge #3896
5613472 
3896: Fix chocolatey error in GH Actions Windows CI r=amesgen a=amesgen

# Description

Like #3075, in order to fix the current CI issue, see e.g. #3891 (comment)



Co-authored-by: amesgen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasagredo jasagredo jasagredo approved these changes

@coot coot Awaiting requested review from coot

@newhoggy newhoggy Awaiting requested review from newhoggy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amesgen @jasagredo