Enabling a better list of warning flags for playground-* & deployment-server. #1208
+189
−175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisajenkins
force-pushed
the
fix-warning-lists
branch
from
3cbbfe6 to
013c036
Compare
shmish111
reviewed
Jul 2, 2019
| {-# OPTIONS_GHC -fno-ignore-interface-pragmas #-} | ||
| {-# OPTIONS_GHC -Wno-missing-signatures #-} | ||
| {-# OPTIONS_GHC -Wno-missing-import-lists #-} |
There was a problem hiding this comment.
what are these needed for?
There was a problem hiding this comment.
I enabled -Wall, which switches these on. But it clashes with the output of mkFunctions.
But since these flags are in all four usecases, I've just rolled them into the cabal file instead.
krisajenkins
force-pushed
the
fix-warning-lists
branch
from
d200f40 to
67b3c88
Compare
…ver. And fixing the problems it raises.
And fixing the problems it raises.
krisajenkins
force-pushed
the
fix-warning-lists
branch
from
06fd119 to
8c5305d
Compare
shmish111
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.