[Builtins] Split 'KnownBuiltinTypeIn' out of 'DefaultKnownBuiltinTypeIn' #6327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/benchmark validation |
|
/benchmark nofib |
|
/benchmark lists |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on '3461df2cc' (base) and '77fa0548e' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'nofib' on '3461df2cc' (base) and '77fa0548e' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
/benchmark nofib |
|
/benchmark lists |
|
Comparing benchmark results of 'lists' on '3461df2cc' (base) and '77fa0548e' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'nofib' on '3461df2cc' (base) and '77fa0548e' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on '3461df2cc' (base) and '77fa0548e' (PR) Results table
|
|
/benchmark nofib |
|
/benchmark lists |
|
/benchmark validation |
|
Click here to check the status of your benchmark. |
|
Click here to check the status of your benchmark. |
|
Click here to check the status of your benchmark. |
…to effectfully/builtins/split-KnownBuiltinTypeIn-out-of-DefaultKnownBuiltinTypeIn
|
/benchmark nofib |
|
Click here to check the status of your benchmark. |
|
/benchmark lists |
|
/benchmark validation |
|
/benchmark nofib |
|
Comparing benchmark results of 'lists' on '613ab5f17' (base) and 'aa80c891c' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on '613ab5f17' (base) and 'aa80c891c' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on '613ab5f17' (base) and 'aa80c891c' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on '613ab5f17' (base) and 'aa80c891c' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'nofib' on '613ab5f17' (base) and 'aa80c891c' (PR) Results table
|
|
/benchmark marlowe |
|
A clear improvement and the Core looks perfect finally, but the improvement is only detectable in very specialized benchmarks and I'm not really sure if it's worth the additional boilerplate. We really should just split the universe into a type-level and a term-level and rip all these benefits and then quite some more, plus simplify the builtins machinery by a lot. I'll think about it a bit more, but most likely I'm going to close this PR in the end. |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'marlowe' on '613ab5f17' (base) and 'aa80c891c' (PR) Results table
|
|
/benchmark lists |
2 similar comments
|
/benchmark lists |
|
/benchmark lists |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on '613ab5f17' (base) and '5668ea0b0' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on '613ab5f17' (base) and '5668ea0b0' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on '613ab5f17' (base) and '5668ea0b0' (PR) Results table
|
|
OK, clearly not worth it. |
effectfully
deleted the
effectfully/builtins/split-KnownBuiltinTypeIn-out-of-DefaultKnownBuiltinTypeIn
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames
KnownBuiltinTypeIntoDefaultKnownBuiltinTypeIn(as it's only useful in the default methods ofMakeKnownInandReadKnownIn) and defines a newKnownBuiltinTypeInthat forces dispatching of the outermostHasTermLevelinstance, which ensures that GHC does not provide it as a dictionary to the builtins code, which would make it necessary to do the dispatching at runtime. I don't really know if it helps performance, but it's easy and I've definitely seen GHC not dispatching constraints when it can, thereby slowing things down.