Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate what kind of Keycloak operator should be supported #37

Closed
fabiobrz opened this issue Apr 27, 2023 · 2 comments · Fixed by #57
Closed

Evaluate what kind of Keycloak operator should be supported #37

fabiobrz opened this issue Apr 27, 2023 · 2 comments · Fixed by #57
Assignees

Comments

@fabiobrz
Copy link
Member

The Keycloak operator implementation is transitioning from a legacy to a Quarkus operator extension one, see https://www.keycloak.org/2022/09/operator-crs

At the moment there is no support in Intersmash for the "New" Keycloak operator, while the current codebase would support the old one.
We need to decide which path to follow regarding provisioning Keycloak via the Operator.

  • Using the new operator would most likely mean to generate the Java model from existing CRDs [1], implement a new KeycloakRealmImportProvisioner and align testsuite implementation to cover it, i.e. based on the Keycloak and KeycloakRealmImport CRDs. The current KeycloakOperatorProvisioner could be temporarily deprecated, until more CRDs are added to the new perator and we verify how the existing implementation works with them.
    PROs: we're aligned with latest, no need to build and push any images. CONs: existing tests relying on missing CRDs won't work.

  • Using the old operator would mean to create a bundle image and an index one that we should maintain and push to some registry, similarly to what is being evaluated for the ActiveMQ Artemis operator provisioner.
    PROs: existing tests relying on missing CRDs will work. CONs: create the images and push tem, not aligned with latest implementation

This issue tracks the effort needed to investigate and identify a solution that can satisfy as many requirements as possible in the context of Keycloak operator based provisioning, but a viable option would also to get to a quick solution in order to enable the testsuite, and then to an ultimate one, later.


  • Environment: testuite/keycloak provisioning
  • Steps to reproduce: N/A
tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue May 11, 2023
tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue May 16, 2023
tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue May 17, 2023
tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue May 17, 2023
tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue May 18, 2023
tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue May 19, 2023
tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue May 19, 2023
tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue May 22, 2023
tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue May 22, 2023
tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue May 23, 2023
@tommaso-borgato
Copy link
Collaborator

WIP in #57

tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue May 24, 2023
tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue May 29, 2023
tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue May 29, 2023
tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue May 29, 2023
tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue May 30, 2023
tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue May 30, 2023
tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue May 30, 2023
@tommaso-borgato
Copy link
Collaborator

we have two option:

  • use the old custom resources with the new operator by using yet another operator which "translates" old custom resources into new custom resources: we'd end up using two operators
  • use the new operator with the new custom resources which are not final yet

we chose the second option which is implemented in #57

tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue May 31, 2023
tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue May 31, 2023
tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue May 31, 2023
tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue Jun 1, 2023
tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue Jun 6, 2023
tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue Jun 9, 2023
tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue Jun 9, 2023
tommaso-borgato added a commit to tommaso-borgato/intersmash that referenced this issue Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants