Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount secrets into bootable jar container in BootableJarImageOpenShiftProvisioner #145

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

mnovak
Copy link
Contributor

@mnovak mnovak commented Feb 9, 2024

Description

Fixes #143

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • I tested my code in OpenShift

@fabiobrz fabiobrz self-requested a review February 9, 2024 11:36
Copy link
Member

@fabiobrz fabiobrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mnovak1 - changes LGTM.

@fabiobrz fabiobrz merged commit 95fa9d4 into Intersmash:main Feb 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BootableJarImageOpenShiftProvisioner does not mount volumes with secrets
2 participants