Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue 153] - Adding property to externalize the WildFly Datasources Galleon pack #154

Merged

Conversation

fabiobrz
Copy link
Member

@fabiobrz fabiobrz commented Feb 28, 2024

Description

Fix #153

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

…alleon pack and pass it to OpenSHift Maven builds, as it's done for similar WildFly bits
@fabiobrz
Copy link
Member Author

/retest

1 similar comment
@fabiobrz
Copy link
Member Author

fabiobrz commented Mar 4, 2024

/retest

@fabiobrz fabiobrz requested a review from marekkopecky March 4, 2024 12:29
@fabiobrz fabiobrz force-pushed the fix.wildfly-config.add-datasources-fp branch from 3336de5 to c43f1b3 Compare March 5, 2024 08:07
@fabiobrz
Copy link
Member Author

fabiobrz commented Mar 5, 2024

/retest

2 similar comments
@fabiobrz
Copy link
Member Author

fabiobrz commented Mar 5, 2024

/retest

@fabiobrz
Copy link
Member Author

fabiobrz commented Mar 5, 2024

/retest

@marekkopecky
Copy link
Collaborator

MR LGTM, merging.

@marekkopecky marekkopecky merged commit 85b26bd into Intersmash:main Mar 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a property to customize the WildFly Datasources Galleon pack for WildFly/EAP 8 deployments
2 participants