Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable testsuite work in progress integration tests #19

Merged

Conversation

fabiobrz
Copy link
Member

@fabiobrz fabiobrz commented Apr 6, 2023

Description

We're disabling all the integration tests that require for the global-test.properties file to be filled in with related properties.
Let's start with WildFly BootableJAR provisioner, and we'll incrementally re-enable the tests.

  • Here we also add a version of this test that is using a Javax based WildFly deployment, i.e. using WildFly 26.1.* bits.
    This could help when testing Intersmash Bootable JAR provisioning tooling against EAP XP, rather than WildFLy, since the currently available bits and images (XP 4) seem still to be javax based.

  • This is also to verify that the OpenShift 4 tests will run on the OpenShift CI infra, see Onboarding Intersmash on OpenShift CI #18

Part of #21

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics - We also bump XTF version to 0.29
  • Code is self-descriptive and/or documented
  • I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

@fabiobrz fabiobrz self-assigned this Apr 6, 2023
@fabiobrz fabiobrz changed the title Disable testsuite wip integration tests [DO NOT MERGE] - Disable testsuite wip integration tests Apr 6, 2023
@fabiobrz
Copy link
Member Author

fabiobrz commented Apr 6, 2023

/test

@openshift-ci
Copy link

openshift-ci bot commented Apr 6, 2023

@fabiobrz: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test intersmash-e2e

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabiobrz
Copy link
Member Author

fabiobrz commented Apr 6, 2023

/test build

@openshift-ci
Copy link

openshift-ci bot commented Apr 6, 2023

@fabiobrz: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test intersmash-e2e

Use /test all to run all jobs.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabiobrz fabiobrz changed the title [DO NOT MERGE] - Disable testsuite wip integration tests Disable testsuite wip integration tests Apr 6, 2023
@fabiobrz fabiobrz changed the title Disable testsuite wip integration tests Disable testsuite work in progress integration tests Apr 6, 2023
@fabiobrz fabiobrz closed this Apr 6, 2023
@fabiobrz fabiobrz reopened this Apr 6, 2023
@fabiobrz fabiobrz marked this pull request as draft April 6, 2023 14:54
@fabiobrz fabiobrz closed this Apr 6, 2023
@fabiobrz fabiobrz reopened this Apr 6, 2023
@fabiobrz fabiobrz marked this pull request as ready for review April 6, 2023 14:56
@fabiobrz fabiobrz marked this pull request as draft April 6, 2023 15:02
@fabiobrz fabiobrz marked this pull request as ready for review April 6, 2023 20:04
@fabiobrz fabiobrz marked this pull request as draft April 7, 2023 09:24
@fabiobrz fabiobrz marked this pull request as ready for review April 7, 2023 09:24
@fabiobrz fabiobrz marked this pull request as draft April 7, 2023 13:43
@fabiobrz fabiobrz marked this pull request as ready for review April 7, 2023 13:44
@fabiobrz fabiobrz marked this pull request as draft April 7, 2023 13:44
@fabiobrz fabiobrz marked this pull request as ready for review April 7, 2023 13:45
@fabiobrz fabiobrz marked this pull request as draft April 8, 2023 07:34
@fabiobrz fabiobrz force-pushed the disable-testsuite-wip-integration-tests branch from 61244db to 68dcd96 Compare April 11, 2023 12:26
@fabiobrz fabiobrz marked this pull request as ready for review April 11, 2023 12:44
@fabiobrz fabiobrz force-pushed the disable-testsuite-wip-integration-tests branch from 68dcd96 to ad9f245 Compare April 11, 2023 13:13
… global-test.properties is filled in with required related properties
Temporary fix for the ProvisionerCleanupTestCase to handle the system:image-puller rolebinding removal, must be investigated
@fabiobrz fabiobrz force-pushed the disable-testsuite-wip-integration-tests branch from ad9f245 to 33bd34a Compare April 11, 2023 13:16
@fabiobrz fabiobrz force-pushed the disable-testsuite-wip-integration-tests branch from 1e39200 to bd8d354 Compare April 11, 2023 14:19
@fabiobrz fabiobrz requested a review from marekkopecky April 11, 2023 15:56
@marekkopecky
Copy link
Collaborator

LGTM, merging, thanks!

@marekkopecky marekkopecky merged commit 954e7f3 into Intersmash:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants