Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #33

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Minor fixes #33

merged 2 commits into from
Apr 27, 2023

Conversation

jstourac
Copy link
Collaborator

@jstourac jstourac commented Apr 26, 2023

Description

Minor change into the codebase to use predefined string constant. Fix for build with Maven 3.9+ by removing of the duplicate version properties in the sample deployment project.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

@openshift-ci
Copy link

openshift-ci bot commented Apr 26, 2023

Hi @jstourac. Thanks for your PR.

I'm waiting for a Intersmash member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabiobrz
Copy link
Member

/ok-to-test

@fabiobrz fabiobrz self-requested a review April 27, 2023 07:41
@fabiobrz fabiobrz self-assigned this Apr 27, 2023
@fabiobrz
Copy link
Member

Thanks @jstourac - changes LGTM, merging!

@fabiobrz fabiobrz merged commit 2dc1d5b into Intersmash:main Apr 27, 2023
@jstourac jstourac deleted the minorFixes branch April 27, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants