Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not reap the world on restart #2

Open
wants to merge 5 commits into
base: release/0.49.x-invoca
Choose a base branch
from
Open

Do not reap the world on restart #2

wants to merge 5 commits into from

Conversation

praymann
Copy link

@praymann praymann commented Dec 9, 2024

Changes proposed in this PR

  • Block watchService() goroutines until we've done an initial population of all services
  • Block watchReapableServices() goroutine until we've done an initial population of all services

Notes

  • I did include some changes to tests to support me running the tests with a specific setup, we can back those out if we want/choose.

gwynethallwright
gwynethallwright approved these changes Dec 19, 2024
View reviewed changes
Copy link

@gwynethallwright gwynethallwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'm happy with retaining the InvocaSpecificConsulConfig for the tests — perhaps that might end up useful for future work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwynethallwright gwynethallwright gwynethallwright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@praymann @gwynethallwright