fix font size and add test

Iota-School · Nov 20, 2023 · 38926c7 · 38926c7
1 parent 508849f
commit 38926c7
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 5 deletions.
diff --git a/nbconvert_html5/pytest_axe.py b/nbconvert_html5/pytest_axe.py
@@ -95,7 +95,7 @@ def from_violations(cls, data):
         for violation in (violations := data.get("violations")):
             for node in violation["nodes"]:
                 for exc in node["any"]:
-                    out.append(cls.new(**exc, target=["target"]))
+                    out.append(cls.new(**exc, target=node["target"]))
         return exceptiongroup.ExceptionGroup(f"{len(violations)} accessibility violations", out)
 
 

diff --git a/nbconvert_html5/templates/a11y/settings.js b/nbconvert_html5/templates/a11y/settings.js
@@ -74,6 +74,7 @@ function setStyle(msg) {
     activityLog(msg);
 }
 function changeFont() {
+    document.forms.settings["font-size"].value;
     setStyle(`font size change`);
 }
 function changeFontFamily() {
@@ -127,7 +128,9 @@ document.querySelectorAll("table[role=grid]").forEach(
 document.forms.settings.elements["color-scheme"].forEach(
     (x) => { x.addEventListener("change", toggleColorScheme) }
 );
-document.forms.settings.elements["font-size"].addEventListener("change", changeFont);
+document.forms.settings.elements["font-size"].addEventListener("change", (x) => {
+    setStyle("change font size");
+});
 document.forms.settings.elements["font-family"].forEach(
     (x) => { x.addEventListener("change", changeFontFamily) }
 );

diff --git a/nbconvert_html5/templates/a11y/style.css b/nbconvert_html5/templates/a11y/style.css
@@ -9,7 +9,7 @@
 }
 
 body {
-    font-size: --var(--nb-font-size);
+    font-size: var(--nb-font-size);
     overflow-x: hidden;
     accent-color: var(--nb-accent-color);
     margin-left: var(--nb-margin);

diff --git a/tests/test_axe.py b/tests/test_axe.py
@@ -135,6 +135,15 @@ def test_dialogs(axe_page, config, notebook, dialog):
     page.click(dialog)
     run_axe_test(page).raises()
 
+
 @config_notebooks_dialog
-def test_settings(axe_page, config, notebook):
-    """test that the settings make their expected changes"""
+def test_settings_font_size(axe_page, config, notebook):
+    """test that the settings make their expected changes"""
+    page = axe_page(get_target_html(config, notebook).absolute().as_uri())
+    font_size = lambda: page.evaluate(
+        """window.getComputedStyle(document.querySelector("body")).getPropertyValue("font-size")"""
+    )
+    assert font_size() == "16px"
+    page.click("[aria-controls=nb-settings]")
+    page.locator("#nb-table-font-size-group").select_option("xx-large")
+    assert font_size() == "32px", "font size not changed"