WIP: Update CarrierWave #4637
Open
WIP: Update CarrierWave #4637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will update CarrierWave to address these two security vulnerabilities: - https://github.com/Iridescent-CM/technovation-app/security/dependabot/188 - https://github.com/Iridescent-CM/technovation-app/security/dependabot/174 We were on version `1.3.2`, this upgraded us to version `2.2.6`. There was a breaking changes upgrading to version `2.0.0`: - https://github.com/carrierwaveuploader/carrierwave/releases/tag/v2.0.0 I had to make changes to the CarrierWave configuration files to address the breaking changes, I followed the README to make the updates: https://github.com/carrierwaveuploader/carrierwave?tab=readme-ov-file#fog Refs: #4636
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will update CarrierWave to address these two security vulnerabilities:
We were on version
1.3.2, this upgraded us to version2.2.6. There were breaking changes upgrading to version2.0.0:I had to make changes to the CarrierWave configuration files to address the breaking changes, I followed the README to make the updates:
https://github.com/carrierwaveuploader/carrierwave?tab=readme-ov-file#fog
Also, I tried to test this locally, but I can't upload any files. I get an error before this upgrade and I get the same error after the upgrade, so I think that means things are wired up correctly. I'm not super confident w/ the changes here, so this one might need to be troubleshooted/debugged on QA.