Assign mentor to club when joining team #5308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viviancan
force-pushed
the
5246-assign-mentor-to-club-when-joining-team
branch
from
f5b8312 to
8f8f219
Compare
viviancan
commented
Jan 17, 2025
| @@ -10,10 +10,10 @@ class Chapter < ActiveRecord::Base | |||
| has_one :legal_contact, dependent: :destroy | |||
| has_one :chapter_program_information, dependent: :destroy | |||
|
|
|||
| has_many :chapter_account_assignments, as: :chapterable, class_name: "ChapterableAccountAssignment" | |||
| has_many :accounts, through: :chapter_account_assignments | |||
| has_many :chapterable_account_assignments, as: :chapterable, class_name: "ChapterableAccountAssignment" | |||
There was a problem hiding this comment.
Not sure if this was (or is going to be) updated in the refactor work. I updated this association to match the chapterable account assignment association in the club model
There was a problem hiding this comment.
Awesome, nice naming alignment! 👍
shaun-technovation
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #5246
This PR updates the mentor invite/join team flow so they can also be assigned to a club