Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with +54 rewards #568

Merged
merged 2 commits into from
Feb 6, 2022
Merged

Conversation

Euphillya
Copy link
Contributor

No description provided.

@Euphillya Euphillya requested a review from dlsf January 16, 2022 18:21
@dlsf dlsf requested a review from PeachesMLG January 16, 2022 18:26
@dlsf dlsf added the bug Something isn't working label Jan 16, 2022
Copy link
Member

@PeachesMLG PeachesMLG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, if we are adding this, I think we should add next page / previous page buttons aswell

@dlsf
Copy link
Member

dlsf commented Jan 17, 2022

I don't really feel like that's needed, rewards just appear after you claim them. Why would you want to claim a specific reward?

@PeachesMLG
Copy link
Member

idk, people are weird

@dlsf
Copy link
Member

dlsf commented Feb 4, 2022

@DoctaEnkoda are you planning on adding pagination support or should someone else do it?

@Euphillya
Copy link
Contributor Author

Frankly, the pagination is useless because we only recover. Why weigh down something that doesn't need it.

@PeachesMLG PeachesMLG merged commit 2115411 into Iridium-Development:master Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants