Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add National Oceanography Centre/British Oceanographic Data Centre's LinkedSystems Erddap server #45

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

adamml
Copy link
Member

@adamml adamml commented Dec 12, 2024

Manually added to README.md and to erddaps.json

Build script used to add to erddaps.js and erddaps.jsonp

All tests passing

Copy link
Contributor

@DsmythMI DsmythMI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Adam,
Couple of minor typos, you have removed "... ocean gliders" from the "Voice of the Ocean" entry above and also typo "LinkedSyatems"

@adamml
Copy link
Member Author

adamml commented Dec 12, 2024

Hey Adam, Couple of minor typos, you have removed "... ocean gliders" from the "Voice of the Ocean" entry above and also typo "LinkedSyatems"

Hi Damian

Thanks for the quick response and catching those, they are updated now

@adamml adamml requested a review from DsmythMI December 12, 2024 16:30
@DsmythMI DsmythMI merged commit b86c139 into IrishMarineInstitute:master Dec 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants