Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attached functions for v5. #11

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Add attached functions for v5. #11

merged 3 commits into from
Dec 18, 2023

Conversation

coltfred
Copy link
Member

Added functions and types for dealing with v5 attached documents.

Copy link

github-actions bot commented Dec 14, 2023

File Coverage Lines
All files 91% 91%
src/v5/key_id_header.rs 86% 86%
src/v5/attached.rs 99% 99%
src/v5/mod.rs 71% 71%
src/v3/mod.rs 99% 99%

Minimum allowed coverage is 24%

Generated by 🐒 cobertura-action against 9022034

Copy link
Member

@giarc3 giarc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just style/comment suggestions

src/v5/attached.rs Outdated Show resolved Hide resolved
src/v5/attached.rs Outdated Show resolved Hide resolved
src/v5/attached.rs Outdated Show resolved Hide resolved
src/v5/attached.rs Outdated Show resolved Hide resolved
src/v5/attached.rs Outdated Show resolved Hide resolved
src/v5/attached.rs Outdated Show resolved Hide resolved
src/v5/attached.rs Outdated Show resolved Hide resolved
@coltfred coltfred merged commit 76e2e20 into main Dec 18, 2023
7 checks passed
@coltfred coltfred deleted the v5-attached branch December 18, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants