Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openseadragon #3

Merged
merged 3 commits into from
Aug 30, 2017
Merged

Add openseadragon #3

merged 3 commits into from
Aug 30, 2017

Conversation

jonathangreen
Copy link
Contributor

@jonathangreen jonathangreen commented Aug 28, 2017

Ticket

Islandora/documentation#693

(I edited the wrong ticket - Nat)!

@whikloj
Copy link
Member

whikloj commented Aug 29, 2017

👍 vagrant up

drupal_config_override:
- configname: openseadragon.settings
key: iiif_server
value: "'http://localhost:8080/cantaloupe'"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be http://localhost:8080/cantaloupe/iiif/2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But thanks as this seems to have revealed that you can't (or I can't) edit and save the IIIF Server URL. The other settings work, but this one seems to remain the same always I'll have to look into it.

@jonathangreen
Copy link
Contributor Author

Fixed that URL. Probably the reason it can't be changed is the way I'm setting the URL in the settings.php file. Maybe we just want to set it with drush instead? Its much easier to automate but putting into the settings.php file.

@whikloj
Copy link
Member

whikloj commented Aug 29, 2017

It looks like it is being changed in the actual config but the changed value is not being picked up so maybe you are right? Perhaps we should template a openseadragon.settings config?

@jonathangreen
Copy link
Contributor Author

jonathangreen commented Aug 29, 2017

Kind of looks like overrides work differently with the new configuration system:
https://www.drupal.org/docs/8/api/configuration-api/configuration-override-system

What do you think? Should I change it to use drush to set the variable?

@whikloj
Copy link
Member

whikloj commented Aug 29, 2017

Yeah I think we may need to.

@jonathangreen
Copy link
Contributor Author

@whikloj I changed how I set the variable. Its kind of ugly, but its idempotent.

@whikloj
Copy link
Member

whikloj commented Aug 29, 2017

Cool, I'll test it tomorrow. That is a bit of a mess, but I don't have any better ideas 😄

@whikloj
Copy link
Member

whikloj commented Aug 30, 2017

Looks good, we still have to manually set the field formatter. Not sure if we could automate that as a separate ansible task? If so, that would be awesome.

👍 merging

@whikloj whikloj merged commit 271314c into master Aug 30, 2017
@jonathangreen jonathangreen deleted the issue-693 branch August 30, 2017 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants