-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add openseadragon #3
Conversation
👍 |
drupal_config_override: | ||
- configname: openseadragon.settings | ||
key: iiif_server | ||
value: "'http://localhost:8080/cantaloupe'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be http://localhost:8080/cantaloupe/iiif/2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But thanks as this seems to have revealed that you can't (or I can't) edit and save the IIIF Server URL. The other settings work, but this one seems to remain the same always I'll have to look into it.
Fixed that URL. Probably the reason it can't be changed is the way I'm setting the URL in the settings.php file. Maybe we just want to set it with drush instead? Its much easier to automate but putting into the settings.php file. |
It looks like it is being changed in the actual config but the changed value is not being picked up so maybe you are right? Perhaps we should template a openseadragon.settings config? |
Kind of looks like overrides work differently with the new configuration system: What do you think? Should I change it to use drush to set the variable? |
Yeah I think we may need to. |
2dd235b
to
cd4a8df
Compare
@whikloj I changed how I set the variable. Its kind of ugly, but its idempotent. |
Cool, I'll test it tomorrow. That is a bit of a mess, but I don't have any better ideas 😄 |
Looks good, we still have to manually set the field formatter. Not sure if we could automate that as a separate ansible task? If so, that would be awesome. 👍 merging |
Ticket
Islandora/documentation#693
(I edited the wrong ticket - Nat)!