Remove unnecessary reverse proxy. #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigelgbanks
force-pushed
the
issue-186-remove-unnecessary-reverse-proxy
branch
from
1542e99 to
6507790
Compare
|
I've tested this with born digital's setup and indeed it works if I replicate the changes from Islandora-Devops/isle-dc#222 |
dannylamb
approved these changes
Mar 3, 2022
|
@nigelgbanks Okay to close this issue if #187 has been merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't remember why it was needed, but I removed it and tested and the everything works as expected.
This requires some changes to
isle-dcuse Islandora-Devops/isle-dc#222 to test.