Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom Makefile #265

Merged
merged 2 commits into from
Jun 29, 2022
Merged

Add custom Makefile #265

merged 2 commits into from
Jun 29, 2022

Conversation

DonRichards
Copy link
Member

This adds a check in the Makefile that looks for the existence of a custom.Makefile. If the file exist it will include it. Full instructions were added to the README.

To test

Using the instructions in the README you should be able to create a custom.Makefile and it should automatically recognize it when you run any make commands.

@ysuarez ysuarez self-requested a review June 15, 2022 17:50
Copy link
Contributor

@ysuarez ysuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR worked as expected. I approve that it gets merged.

@ysuarez
Copy link
Contributor

ysuarez commented Jun 29, 2022

At today's tech call we thought of "changing the direction of composition," in other words have the custom Makefile include the project's default Makefile instead of the other way around like in this PR.

@ysuarez ysuarez merged commit 8b45586 into development Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants