Update objects and media documentation #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc sprint
dannylamb
reviewed
Nov 18, 2019
cderven
reviewed
Nov 19, 2019
cderven
reviewed
Nov 19, 2019
|
Hi - both the Nodes and Media files look pretty good to me. I left a few comments for each file. |
|
Thanks, @cderven! I've made a few updates. Please let me know if I need to make any other changes. |
rosiel
reviewed
Nov 19, 2019
rosiel
reviewed
Nov 20, 2019
cderven
reviewed
Nov 20, 2019
Merged
|
I've added more detail on using the Paged Content viewer, @cderven. Let me know how it goes. |
cderven
reviewed
Nov 22, 2019
whikloj
requested changes
Nov 22, 2019
|
@whikloj I made the two grammar changes. I then went and updated the collections page screenshots. I only took two new ones and the others I simply cropped out the Tools block as the rest of the image is mostly consistent between Carapace themes. |
|
@whikloj, could you please re-review? |
whikloj
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #1040
What does this Pull Request do?
Updates the objects and media documentation. Also updates references in context and collection to renamed files used in multiple places.
How should this be tested?
Preview the pages and look them over. Do they make sense and read well? Are there any typos or poor formatting?
Additional Notes:
There's no reviewer signed up yet, so whoever reviews, please grab the credit in that spreadsheet.
Interested parties
@Islandora/8-x-committers