Clawdit #739
Merged
Clawdit #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seth-shaw-unlv
suggested changes
Oct 21, 2019
There was a problem hiding this comment.
Wanna edit contributing and the text extraction submodule README while you're at it?
$ grep -r claw *
CONTRIBUTING.md:The group meets each Wednesday at 1:00 PM Eastern. Meeting notes and announcements are posted to the [Islandora community list](https://groups.google.com/forum/#!forum/islandora) and the [Islandora developers list](https://groups.google.com/forum/#!forum/islandora-dev). You can view meeting agendas, notes, and call-in information [here](https://github.com/Islandora/documentation/wiki#islandora-claw-tech-calls). Anybody is welcome to join the calls, and add items to the agenda.
modules/islandora_text_extraction/README.md:On an Ubuntu/Debian machine like the default claw playbook run
|
The tech call URL should be |
|
@seth-shaw-unlv Ok, I've gone through all the submodules now. |
|
@dannylamb, just those few little things I mentioned above, plus islandora_text_extraction is missing it's CONTRIBUTING.md. |
|
@seth-shaw-unlv Kk, done. |
seth-shaw-unlv
approved these changes
Oct 24, 2019
|
@dannylamb, coding standards. |
|
😭 |
|
Alright, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue: (Islandora/documentation#1267)
What does this Pull Request do?
Overhaul's README to meet our template, general de-CLAWing, and some better form text in a few spots that I touched up as I went along.
How should this be tested?
Give the README a good once over.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers