Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing use statement #851

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Add missing use statement #851

merged 1 commit into from
Oct 4, 2021

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Oct 4, 2021

GitHub Issue: n/a

See this comment, but essentially a use statement is missing.

What does this Pull Request do?

Adds the missing use statement

How should this be tested?

This appeared when installing the module (during the creation of a playbook instance), but I imagine if you uninstalled islandora (and all the dependant modules) and tried to re-install it you would get the error.

Interested parties

@Islandora/8-x-committers (@rosiel and @alxp)

@adam-vessey
Copy link

Whoops... Though really, this exception shouldn't ever really be seen, if a key is configured... funnily enough, we (DGI) are also presently missing this use statement in our "hotfixes" branch; however, our provisioning sets up/configures the key (injecting things with "config_override", IIRC?) before installing Islandora, so we never saw the error.

@adam-vessey adam-vessey merged commit 2923a1a into Islandora:8.x-1.x Oct 4, 2021
@whikloj
Copy link
Member Author

whikloj commented Oct 4, 2021

Yeah not sure why this shows up during the playbook installation. But good to catch it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants