Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset pseudo field in display modes automatically #899

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Sep 14, 2022

GitHub Issue: Islandora/documentation#1523

What does this Pull Request do?

Any entity/bundle types that have the Fedora URI field removed from them are now used to

  • query for all entity view displays that contain the pseudo field in the content (read: visible)
  • remove the pseudo field from these entity view displays

What's new?

  • Does this change add any new dependencies? No
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? No
  • Could this change impact execution of existing code? No

How should this be tested?

  1. Configure an entity bundle's field display to show the Fedora URI. (Admin -> Structure -> Content Type -> Repository Item -> Manage Display)
  2. Create some of these types.
  3. See they have the Fedora URI
  4. Unselect the entity bundle on the Islandora Core Settings form and Save
  5. See the entities no longer have the Fedora URI.
  6. See that (unfortunately) the Fedora URI is now in the disabled section of the entity field display form (see below)

Note: My understanding of Drupal 8/9 cache is not strong and I cannot figure out how to determine what to "clear" to get the Fedora URI to disappear from the (now) unselected entity/bundles on the page described in step 1 above. Only a full cache clear seems to have the desired impact. I'd appreciate some help with that.

Documentation Status

  • Does this change existing behaviour that's currently documented? no
  • Does this change require new pages or sections of documentation? not really
  • Who does this need to be documented for?
  • Associated documentation pull request(s): ___ or documentation issue ___

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers ( @rosiel, @mjordan & @seth-shaw-asu )

@whikloj whikloj marked this pull request as ready for review September 14, 2022 21:32
@whikloj
Copy link
Member Author

whikloj commented Sep 14, 2022

I'll have a look but it seems something has changed in 9.5-dev in the last 6 days to cause the modules to not be installed. Could be the deprecation of the rdf module perhaps.

@whikloj
Copy link
Member Author

whikloj commented Sep 15, 2022

Two of the modules that are failing are restui and openseadragon. Could be more but I had to stop playing with it. Failure seems related to this change (https://www.drupal.org/node/3292540) from Sept 13, 2022, which would explain why PRs from 7 days ago (#898) passed the tests but new ones don't.

Unsure, whether to spend anytime figuring it out. We (for openseadragon) don't seem to be doing the things they mention in the ticket related to using _serviceId but 🤷

@seth-shaw-asu seth-shaw-asu merged commit 0948436 into Islandora:2.x Sep 21, 2022
@whikloj whikloj deleted the issue-1523 branch September 21, 2022 20:01
rosiel pushed a commit to rosiel/islandora that referenced this pull request Nov 7, 2022
* Unset pseudo field in display modes automatically
* Clear the correct cache and fix coder issues
rosiel pushed a commit to rosiel/islandora that referenced this pull request Dec 14, 2022
* Unset pseudo field in display modes automatically
* Clear the correct cache and fix coder issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants