Sunsetting: Remove config enforcement, and post-update hook to do so for existing sites #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #74 / Islandora-Devops/islandora-starter-site#2
Release pull requests, etc.)
What does this Pull Request do?
Introduces a (post-)update hook and documents its usage in the process of removing of this module.
What's new?
The module is removable without removing its config, with a new post-update hook to facilitate existing installations.
(i.e. Regeneration activity, etc.)? No.
How should this be tested?
Easiest might be to:
standard
islandora-playbook
, to get a a base environment withislandora_defaults
still presentstandard.yml
intoislandora-playbook
'svars
directoryISLANDORA_INSTALL_PROFILE=standard vagrant up
drush config:export sync
README.md
/var/www/html/drupal/composer.json
, pointing at the repo containing the branch being merged here, and to specify it in lieu of^3
... so, something like:composer require "islandora/islandora_defaults:dev-fix/config-enforcement as 3.x-dev"
as the example output of execution presently uses instead of thecomposer require "islandora/islandora_defaults:^3"
which is in the main doc.drush config:export sync --diff
enforced
statements targetingislandora_defaults
going away, and entries from thecore.extension
changing according to the modules that were uninstalled (and possibly some re-ordering of properties just due to config doing config things).Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers