Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow opening of a specific POI in a group #787

Closed
zstadler opened this issue Aug 19, 2018 · 3 comments
Closed

Allow opening of a specific POI in a group #787

zstadler opened this issue Aug 19, 2018 · 3 comments
Assignees
@HarelM
Labels
enhancement Low Nice to have or feature or a very edge case bug
Milestone
Version 8.5

Comments

@zstadler
Copy link
Member

Feature

What I expect to happen

When several nearby POIs are grouped, and the mouse hovers the group's icon, it will be possible to click on a specific POI name in order to open it.
For example, allow clicking on each of the POIs in the list below
image

What really happened

The list disappears as soon as the mouse is moved to one of its items. As a result, the group must be separated, and the appropriate POI located in the zoomed-in map:
image

What I did that caused the issue - step by step

  1. Enable all POI layers
  2. Open https://israelhiking.osm.org.il/map/15/32.4661/35.5398
  3. Hover the mouse on the group in the center of the map
  4. Try to click on one of the item in the list
@HarelM HarelM added enhancement Low Nice to have or feature or a very edge case bug labels Sep 2, 2018
@HarelM
Copy link
Member

HarelM commented Sep 2, 2018

I don't see in the leaflet documentation an option to delay tooltip vanishing time - therefore it seems that supporting this needs to hack how the tooltip works, which I prefer not to.
https://leafletjs.com/reference-1.3.4.html#tooltip
Any ideas are welcome...

@HarelM
Copy link
Member

HarelM commented Sep 20, 2018

Might be possible if we migrate to OpenLayers. Pending #669 decision.

@HarelM
Copy link
Member

HarelM commented Oct 24, 2018

Changing UX of hover on cluster due to Openlayer migration.
This means that clicking on a cluster will simply open this popup instead of zooming in which the user can easily do by clicking the + or using touch.

HarelM added a commit that referenced this issue Oct 24, 2018
@HarelM
Resolves #787 - Allow opening of a specific POI in a group.
b159443 
Related to #669.
@HarelM HarelM closed this as completed Oct 24, 2018
@HarelM HarelM self-assigned this Oct 24, 2018
@HarelM HarelM added this to the Next Release milestone Oct 24, 2018
HarelM added a commit that referenced this issue Dec 5, 2018
@HarelM
Merge Openlayers branch to master (#877)
8b6df7f 
* Support map rotation #669 - initial commit. a complete rewrite of the site to use openlayer, still not complete. Resolves #402 - Support global undo instead of undo per route.

* Support map rotation #669 - lint fixes, added north icon.

* Support map rotation #669 - Fix compilation due to unused events.

* Support map rotation #669 - Remove events and some leaflet usages.

* Support map rotation #669 - Fix compilation, removed more $events.

* Support map rotation #669 - Fix compilation

* Support map rotation #669 - Fix compilation due to unneeded classes.

* Support map rotation #669 - remove some unused code.

* Support map rotation #669 - Added clustering and route recording, fixed tranlation typos, added missing translations, fixed other small stuff to make things work.

* Support map rotation #669 - added make all route points editable.

* Replaced wrench with 3 vertical dots. #669

* Support various clear route options #669

* Resolves #787 - Allow opening of a specific POI in a group.
Related to #669.

* Support map rotation #669 - Added mapserver support using xyz tiles.

* Support map rotation #669 - Added snapping back. removed unused code.

* Support map rotation #669 - bring back tests.

* Support map rotation #669 - small correction related to cordova.

* Support map rotation #669 - remove leaflet, fixed delete route, updated file saver.

* Support map rotation #669 - Fix lint.

* Support map rotation #669 - Fix tests.

* Support map rotation #669 - Split android and web builds

* Support map rotation #669 - Split build, fix yml.

* Support map rotation #669 - Fix compilation after lint required fixes  :-/

* Support map rotation #669 - Throw if angular build fails.

* Support map rotation #669 - Fix android build due to split

* Support map rotation #669 - Updated version to 8.0

* Support map rotation #669 - Added GPS location interaction.

* Support map rotation #669 - Moved most of the popups to be overlays.

* Support map rotation #669 - Fix production compilation

* #669 - Moved pure map components to a folder.

* #669 - fix compilation.

* Fixed issue with version in GPX and improve description of uploaded OSM trace.

* Support map rotation #669 - Added traces layer and ability to manipulate.

* Fixes #856 - Fix failing android builds

* Support map rotation #669 - Fix tests, fix issue with animation override when following GPS location.

* Support map rotation #669 - facilitate drag and drop of a file.

* Support map rotation #669 - Fix fit to bounds. Fix legend. Fix move to search results.

* Support map rotation #669 - add zoom animation for zoom-in/out

* Support map rotation #669 - remove unwanted OSM layer.

* Support map rotation #669 - Moved layers and user to state management.

* Support map rotation #669 - Make advance route actions under a ... button

* Support map rotation #669 - Fix lint

* Support map rotation #669 - Fix production build, remove opacity from base layer, changed opacity slider to be green.

* Support map rotation #669 - reverse route in route properties, fixed some mouse events, fixed visibilty of route.

* Support map rotation #669 - Fix toggle category layer causes collapse.

* Support map rotation #669 - Fix incorrect color and weight.

* Support map rotation #669 - Fix production compilation due to missing method.

* Error adding routes to OSM #848 - Might be related, but might be a different issue.

* Support map rotation #669 - add route direction

* Support map rotation #669 - show direction only in readonly mode, show route points only in route editing mode. emit null when dragging interaction to hide hover marker.

* Support map rotation #669 - Fix opening a file that has only markers.

* Support map rotation #669, Support offline tiles #783 - Added PouchDB, update technology stack

* #669 - Update reducer action decorator to hold all the relevant classes.

* Support map rotation #669 - Show searchresult marker, fix production build

* Support map rotation #669 - Fix lint, move search results to poi service.

* Support map rotation #669 - Improve search results icon and some errors.

* Support map rotation #669 - improve private POI UX. added icons to private POI back.

* Support map rotation #669 - support database writing in another thread.

* Support map rotation #669 - make sure font loads before anything else to prevent missing icons on the map.

* Avoid using environment but use running context instead.

* Support map rotation #669 - Fix issue with a segment with a single point.

* Support map rotation #669 - add tooltip to north-up

* Support map rotation #669 - do not store and read state when runnning inside iFrame.

* Support map rotation #669 - Add extra data indicator.

* Resolves  #861 - Update to angular 7

* Support map rotation #669 - Add coordinates and height to private POI dialog. remove comments, added some TODOs.

* Update to angular 7 #861 - Update typescript to 3.1.6, remove unused import.

* Update to angular 7 #861 - remove css files to reduce build time? change appveyor worker cloud

* Support map rotation #669 - Small fix to route editing.

* Update to angular 7 #861 - downgrade to 7.0.4 to check if this solves build issues.

* Another attempt to fix appveyor run...

* Support map rotation #669 - Make recording work.

* Support map rotation #669 - fixed issue with undo.
Update to angular 7 #861 - reduce angular-cli back to 6.1.6 to prevent out of memory.

* Update to angular 7 #861 - Increase memory limit to all commands.

* Update to angular 7 #861 - Update typescript for cli.

* Update to angular 7 #861 - Fix lint.

* Fixes #866 - Geo-tagged images won't open (beta)

* Moved to ngx-openlayers next version. #669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HarelM HarelM

Labels
enhancement Low Nice to have or feature or a very edge case bug
Projects
None yet
Milestone
Version 8.5
Development

No branches or pull requests
2 participants
@zstadler @HarelM