feat(svelte-5): move to svelte 5 runes #326
Conversation
dvcol
force-pushed
the
svelte-5
branch
3 times, most recently
from
8deea2c to
cee2ec2
Compare
There was a problem hiding this comment.
Thank you for getting started on this! Certainly something we need to do.
- Can you please do a separate PR first just for the linter? Otherwise it's impossible to review the changes.
- Until Svelte 5 is stable, we should probably have a separate branch for Svelte 5 support
| @@ -0,0 +1,213 @@ | |||
| <script> | |||
| import {onDestroy} from 'svelte' | |||
There was a problem hiding this comment.
You probably have a linter installed that changed the formatting of this file entirely :( Because of that, it's pretty much impossible for us to review this...
Before this PR, could you open a separate one where you just run the linter (without any code changes)? Then we can at least see what's different.
(Feel free to include other changes such as the .gitignore ones if relevant)
There was a problem hiding this comment.
I do use prettier, but most of the noise is because of a code split of the router in dedicated classes (to better understand the code structure) and the switch to vite instead of rollup (I had issues making it work with Svelte 5).
I've restructured the branch to isolate the commit with the pure svelte-5 migration here if that helps.
However, I've now opted to develop a custom router that is more suited to my needs, so I'm unsure if I'll be able to contribute much more to this PR.
Feel free to close it if you don't think it'll be helpful in the future :)
|
any headway on this guys? safe to use? @dvcol @ItalyPaleAle |
|
A propper migration work started from one of the maintainer, follow it here :) |
Hello :)
I saw this issue, but when I tried to use the router with the latest version of svelte-5 it didn't seem to work.
It may be due to the changes in side effects and reactivity (even though it should be backwards compatible according to the official docs ?)
Anyway, I did a quick and dirty migration to serve my needs, and I thought it might be of help :)
I didn't test it thoroughly because my needs are quite basic (I'm especially doubting the reactivity of the scroll restore function),