Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

[BUG] Account Buttons Text Getting Squished #2851

Open
1 task done
Psypher1 opened this issue Dec 26, 2023 · 27 comments
Open
1 task done

[BUG] Account Buttons Text Getting Squished #2851

Psypher1 opened this issue Dec 26, 2023 · 27 comments
Labels
approved Approved by the Ivy Wallet team. Ready for dev bug Something isn't working good first issue Good for newcomers keep Keep it from automatically getting closed by Stale P2 Nice to have

Comments

@Psypher1
Copy link

Please confirm the following

Describe the bug

Add Income and Add Expense buttons in the wallets don't render the text correctly. It's either cut out or makes the button look strange.

To Reproduce

  1. Create an account
  2. Add income/expense from that accound

Expected behavior

The buttons should look the same as the rest of the app
Wallet

Screenshots

No response

Smartphone

Samsung Galaxy S10 Plus

Additional context

No response

@Psypher1 Psypher1 added the bug Something isn't working label Dec 26, 2023
@ILIYANGERMANOV ILIYANGERMANOV added the approved Approved by the Ivy Wallet team. Ready for dev label Dec 26, 2023
@sebesti0n
Copy link

Hey @Psypher1 i want to work on this, Please assign me this.

@Psypher1
Copy link
Author

Psypher1 commented Dec 31, 2023

Hey @Psypher1 i want to work on this, Please assign me this.

I don't think I have the permissions to assign people

@sebesti0n
Copy link

okay

@sebesti0n
Copy link

@ILIYANGERMANOV please assign me this

@ILIYANGERMANOV
Copy link
Collaborator

@sebesti0n say the "magic words" from CONTRIBUTING instructions in the repo, it's fully automated

@mokhtarmoustafa
Copy link

I'm on it

@ivywallet
Copy link
Collaborator

Thank you for your interest @mokhtarmoustafa! 🎉
Issue #2851 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please unassign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

@mokhtarmoustafa
Copy link

Screenshot_20240101_144226
@Psypher1 what is the device that you used because everything is well from my side, look the attached image

@Psypher1
Copy link
Author

Psypher1 commented Jan 4, 2024

Screenshot_20240101_144226 @Psypher1 what is the device that you used because everything is well from my side, look the attached image

Samsung Galaxy S10 Plus

@github-actions github-actions bot added the Stale No activity, will be automatically closed soon. label Feb 4, 2024
@ILIYANGERMANOV ILIYANGERMANOV added keep Keep it from automatically getting closed by Stale and removed Stale No activity, will be automatically closed soon. labels Feb 4, 2024
@Rick-AB
Copy link
Contributor

Rick-AB commented Feb 14, 2024

@ILIYANGERMANOV as this issue is device dependent, one solution might be to have an autoscaling text composable that fits in its container with the set padding.

@ILIYANGERMANOV
Copy link
Collaborator

@ILIYANGERMANOV as this issue is device dependent, one solution might be to have an autoscaling text composable that fits in its container with the set padding.

We need to reduce paddings probably

@ILIYANGERMANOV ILIYANGERMANOV added good first issue Good for newcomers P2 Nice to have labels Apr 1, 2024
@TanishMoral11
Copy link

I'm on it

@ivywallet
Copy link
Collaborator

⚠️ Hey @TanishMoral11, this issue is already taken by @mokhtarmoustafa.
Do not start working on it!
Please, pick another one.

Also, make sure to read our Contribution Guidelines.

@BruceSuperProgramer
Copy link

I'm on it

@ivywallet
Copy link
Collaborator

Thank you for your interest @BruceSuperProgramer! 🎉
Issue #2851 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

@BruceSuperProgramer
Copy link

BruceSuperProgramer commented Sep 11, 2024

I am able to reproduce this issue continue working on it tmr.

@BruceSuperProgramer
Copy link

The issue occurs when the user selects a larger font size in their device settings, causing text misalignment across multiple screens. It’s not limited to just one screen; several screens exhibit the same problem when the default font size is too large. Should I adjust the UI styling to accommodate larger fonts, or disable font scaling in the app to prevent it from being affected by the user’s default font size settings? @ILIYANGERMANOV

@ILIYANGERMANOV
Copy link
Collaborator

Hi, just fix the UI scaling on the screen where this bug is reported. The fix shouldn't break the UI for normal device with normal font

@BruceSuperProgramer
Copy link

Hi, just fix the UI scaling on the screen where this bug is reported. The fix shouldn't break the UI for normal device with normal font

The core issue isn’t the individual text or button, but rather how to handle fontSize consistently across the entire app when a user has large font settings enabled on their device.

This is not a matter of fixing specific areas one by one but requires a solution that addresses the entire app. For example, the text inside the 'Add Income' button is almost overflowing the button's space because the larger font setting causes the text to nearly break into two lines. Similarly, in the 'Add Expense' button, the text already wraps to two lines since it can’t fit on one. It’s not possible to maintain the current text size and ensure it stays on one line—it simply won’t fit."

I do not know how to fix it at moment could any one provide me some guidance or please unassign me from this task so others could pick up.

@ILIYANGERMANOV
Copy link
Collaborator

There aew couple of ways:

  1. Make UIs scaleable and scrollable
  2. Use provide LocalDensity.current with upper bounded font scale

The issue with this one is that it happens on normal font size setting on some devices. That annoys users

@sahishnu111
Copy link

“I am new to this, but I would like to contribute to resolving this issue. May I give it a try?”

@ILIYANGERMANOV
Copy link
Collaborator

https://github.com/Ivy-Apps/ivy-wallet/blob/main/CONTRIBUTING.md

@sahishnu111
Copy link

sahishnu111 commented Oct 4, 2024

Screenshot 2024-10-04 151950

Thank you for your response. I have cloned the repository and attempted to replicate the issue as described. However, I am not encountering any issues on my Android emulator. Here are the details of my setup:

  • Device Skin: SAMSUNG S10 (official website)
  • API Level: 31
  • Android Version: 12 (as Samsung stopped support for this device after this update)

Additionally, I used the Layout Inspector to investigate the issue further.
Could you assign this work for me, so I can look more into this issue.

@ILIYANGERMANOV
Copy link
Collaborator

@sahishnu111 increase font size from settings and pick a smaller emulator device

@sahishnu111
Copy link

Thank you for your feedback. Based on the information provided, I was able to recreate a similar issue within the app. However, the problem does not occur with the same button but in different areas. Specifically, it becomes difficult to click buttons, and the alignment changes unexpectedly.
After increasing the font size more than 50% to 60% this started to happen
small phone screenshot android github issue4
small phone screenshot android github issue3
small phone screenshot android github isuue
small phone screenshot android github issue

@sahishnu111
Copy link

@ILIYANGERMANOV sir , can i work on this issue

@Mj-br
Copy link
Contributor

Mj-br commented Oct 31, 2024

Hi @sahishnu111 ! If you want to work on this just say the "magic words" from CONTRIBUTING instructions in the repo, it's fully automated!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Approved by the Ivy Wallet team. Ready for dev bug Something isn't working good first issue Good for newcomers keep Keep it from automatically getting closed by Stale P2 Nice to have
Projects
None yet
Development

No branches or pull requests

10 participants