Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

German translation #2826

Conversation

CedricLindigkeit
Copy link
Contributor

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the main branch.
  • I've read the Contribution Guidelines and my PR doesn't break the "Contributing Rules".
  • I've read the Architecture Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • 🎬 I've attached a screen recoding of the changes.

Tip: drag & drop the video to the PR description.

Screenrecorder-2023-11-22-22-36-42-63-2-2.mp4

What's changed?

Tip: you can attach screenshots using a markdown table.

1700688752057

1700688752053

1700688752049

1700688752045

1700688752041

1700688752036

1700688752033

1700688752025

1700688752025
|:----------|:----------|:----------|:----------|:----------|:----------|:----------|:----------|:----------|:-----------|
1700688752021

1700688752017

1700688752013

1700688752009

1700688752005

1700688752002

1700688751998

1700688751994

1700688751991

1700688751987

1700688751984

1700688751980

1700688751975

Describe with a few bullets what's new:

  • Translated every NOT HARDCODED string into German

💡 Tip: Please, attach screenshots and screen recordings. It helps a lot!

Risk Factors

What may go wrong if we merge your PR?

  • Nothing

In what cases your code won't work?

  • It does work. Keep in mind hardcoded strings HAVE NOT been translated

Does this PR closes any GitHub Issues?

Check Ivy Wallet Issues.

Replace ISSUE_NUMBER with your issue number (for example Closes #1234). If you've done that correctly, you'll see the issue title linked when previewing your PR description.

Troubleshooting CI failures

If you see any of the PR checks failing (❌) go to Actions and find it there. Or simply click "Details" next to the failed check and explore the logs to see why it has failed.

Detekt

Detekt is a static code analyzer for Kotlin that we use to enforce code readibility and good practices.

To run Detekt locally:

./gradlew detekt

If the Detekt errors are caused by a legacy code, you can suppress them using a basline.

Detekt baseline (not recommended)

./scripts/detektBaseline.sh

Lint

We use the standard Android Lint plus Slack's compose-lints as an addition to enforce proper Compose usage.

To run Lint locally:

./scripts/lint.sh

If the Lint errors are caused by a legacy code, you can suppress them using a basline.

Lint baseline (not recommended)

./scripts/lintBaseline.sh

Unit tests

If this job is failing this means that your changes break an existing unit test. You must identify the failing tests and fix your code.

To run the Unit tests locally:

./gradlew testDebugUnitTest

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand German but seems like an excellent work!! 👏 Thanks for including all these screenshots 💯

@ILIYANGERMANOV
Copy link
Collaborator

CI is failing, ping me when you resolve it so we can merge the PR 👍

@CedricLindigkeit
Copy link
Contributor Author

I can't figure out what's going wrong right now, so I might check again tomorrow.

"It works on my machine"™ - The same tasks are successful on my computer .-.

@ILIYANGERMANOV
Copy link
Collaborator

No rush^ Just make sure to comment if the PR get automatically marked as "Stale"

@CedricLindigkeit
Copy link
Contributor Author

Found the issue: Android Resource Linking fails.

Don't know what's causing this yet, but maybe I'll find out.

@github-actions github-actions bot added the Stale No activity, will be automatically closed soon. label Nov 25, 2023
@ILIYANGERMANOV ILIYANGERMANOV removed the Stale No activity, will be automatically closed soon. label Nov 25, 2023
@ILIYANGERMANOV
Copy link
Collaborator

Removed Stale label

@github-actions github-actions bot added the Stale No activity, will be automatically closed soon. label Nov 28, 2023
@github-actions github-actions bot closed this Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Stale No activity, will be automatically closed soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate the App into German Example issue
2 participants