This repository has been archived by the owner on Nov 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 742
German translation #2826
Closed
CedricLindigkeit
wants to merge
8
commits into
Ivy-Apps:main
from
CedricLindigkeit:German_translation_#2825
Closed
German translation #2826
CedricLindigkeit
wants to merge
8
commits into
Ivy-Apps:main
from
CedricLindigkeit:German_translation_#2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vious reason not to
ILIYANGERMANOV
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand German but seems like an excellent work!! 👏 Thanks for including all these screenshots 💯
CI is failing, ping me when you resolve it so we can merge the PR 👍 |
I can't figure out what's going wrong right now, so I might check again tomorrow. "It works on my machine"™ - The same tasks are successful on my computer .-. |
No rush^ Just make sure to comment if the PR get automatically marked as "Stale" |
Found the issue: Android Resource Linking fails. Don't know what's causing this yet, but maybe I'll find out. |
github-actions
bot
added
the
Stale
No activity, will be automatically closed soon.
label
Nov 25, 2023
Removed Stale label |
github-actions
bot
added
the
Stale
No activity, will be automatically closed soon.
label
Nov 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) Checklist
Please check if your pull request fulfills the following requirements:
main
branch.Screenrecorder-2023-11-22-22-36-42-63-2-2.mp4
What's changed?
Tip: you can attach screenshots using a markdown table.
|:----------|:----------|:----------|:----------|:----------|:----------|:----------|:----------|:----------|:-----------|
Describe with a few bullets what's new:
Risk Factors
What may go wrong if we merge your PR?
In what cases your code won't work?
Does this PR closes any GitHub Issues?
Check Ivy Wallet Issues.
Troubleshooting CI failures
If you see any of the PR checks failing (❌) go to Actions and find it there. Or simply click "Details" next to the failed check and explore the logs to see why it has failed.
Detekt
Detekt is a static code analyzer for Kotlin that we use to enforce code readibility and good practices.
To run Detekt locally:
If the Detekt errors are caused by a legacy code, you can suppress them using a basline.
Detekt baseline (not recommended)
Lint
We use the standard Android Lint plus Slack's compose-lints as an addition to enforce proper Compose usage.
To run Lint locally:
If the Lint errors are caused by a legacy code, you can suppress them using a basline.
Lint baseline (not recommended)
Unit tests
If this job is failing this means that your changes break an existing unit test. You must identify the failing tests and fix your code.
To run the Unit tests locally: