Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly parse n_jobs=-1 (#96) #102

Merged
merged 1 commit into from
Jun 9, 2019
Merged

Conversation

jpweytjens
Copy link
Contributor

index_split can not parse n_jobs = -1. A solution is to pass the actual maximum number of cpu cores instead, as provided by joblib.cpu_count

@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #102 into master will decrease coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage    77.2%   77.17%   -0.03%     
==========================================
  Files          33       33              
  Lines        2338     2340       +2     
  Branches      376      377       +1     
==========================================
+ Hits         1805     1806       +1     
+ Misses        408      407       -1     
- Partials      125      127       +2
Impacted Files Coverage Δ
recordlinkage/base.py 80.31% <50%> (-0.17%) ⬇️
recordlinkage/algorithms/compare.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87a5f4a...e493019. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #102 into master will decrease coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage    77.2%   77.17%   -0.03%     
==========================================
  Files          33       33              
  Lines        2338     2340       +2     
  Branches      376      377       +1     
==========================================
+ Hits         1805     1806       +1     
+ Misses        408      407       -1     
- Partials      125      127       +2
Impacted Files Coverage Δ
recordlinkage/base.py 80.31% <50%> (-0.17%) ⬇️
recordlinkage/algorithms/compare.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87a5f4a...e493019. Read the comment docs.

@J535D165 J535D165 merged commit f3fbf37 into J535D165:master Jun 9, 2019
@J535D165
Copy link
Owner

J535D165 commented Jun 9, 2019

Thanks for your contribution @jpweytjens

@jpweytjens jpweytjens deleted the fix_njobs branch November 28, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants