Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix accuracy for pandas.MultiIndex fixes #84 #109

Merged
merged 2 commits into from
Jul 12, 2019

Conversation

mayerantoine
Copy link
Contributor

This fix allow the accuracy function to accept a pandas.MultiIndex as mentioned in the docs i.e (When the argument is a pandas.MultiIndex, the length of the index is used)

@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

Merging #109 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   76.84%   76.86%   +0.01%     
==========================================
  Files          33       33              
  Lines        2354     2356       +2     
  Branches      379      380       +1     
==========================================
+ Hits         1809     1811       +2     
  Misses        415      415              
  Partials      130      130
Impacted Files Coverage Δ
recordlinkage/measures.py 89.52% <100%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 423a2eb...98a7e6d. Read the comment docs.

@J535D165
Copy link
Owner

Thanks for fixing this. Can you do the same for confusion_matrix (before tn = true_negatives(links_true, links_pred, total)) and specificity as well?

@J535D165
Copy link
Owner

Thanks a lot for your involvement in the project!

(btw tests fail due to an upstream problem with flake)

@J535D165 J535D165 merged commit 2524fad into J535D165:master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants