Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fixes #258

Merged
merged 1 commit into from
Mar 14, 2024
Merged

CI fixes #258

merged 1 commit into from
Mar 14, 2024

Conversation

JezSw
Copy link
Contributor

@JezSw JezSw commented Mar 14, 2024

Description

Allowing tee for pytest in linux to fail. Updating setup python and upload artifact action versions.
Fixes #257

Type of change

Please select what type of change this is.

  • Bug fix (non-breaking change which fixes an issue)
  • New benchmark
    • Non-breaking change which entirely uses exisiting classes, structure etc
    • Breaking change which has implemented new/modified classes etc
  • New feature
    • Non-breaking change which adds functionality
    • Breaking change fix or feature that would cause existing functionality to not work as expected

Other changes

  • This change requires a documentation update
  • (If Benchmark) This requires additional data that can be obtained from:
    • Benchmark data 1
    • Benchamrk data 2

Testing

Tested on fork (see https://github.com/JezSw/JADE/actions/runs/8278615552)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • General testing
    • New and existing unit tests pass locally with my changes
    • Coverage is >80%

@alexvalentine94 alexvalentine94 merged commit 838a993 into JADE-V-V:linux Mar 14, 2024
0 of 4 checks passed
@JezSw JezSw deleted the CIfixes branch March 14, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants