Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix standard deviation sheet #307

Conversation

dodu94
Copy link
Member

@dodu94 dodu94 commented Jul 4, 2024

Description

The standard deviation sheet was computed as the absolute difference between the results (reference-target) divided by the relative error value of the reference. The actual quantity of interest here is instead the absolute difference divided by the product of ref error times ref value in order to divide by the absolute error. This small PR fixes this issue in the Sphere and SphereSDDR benchmarks.

Type of change

Please select what type of change this is.

  • Bug fix (non-breaking change which fixes an issue)
  • New benchmark
    • Non-breaking change which entirely uses exisiting classes, structure etc
    • Breaking change which has implemented new/modified classes etc
  • New feature
    • Non-breaking change which adds functionality
    • Breaking change fix or feature that would cause existing functionality to not work as expected

@dodu94 dodu94 requested a review from alexvalentine94 July 4, 2024 09:46
@alexvalentine94 alexvalentine94 merged commit ccbb1b2 into developing Jul 4, 2024
8 checks passed
@dodu94 dodu94 deleted the fix-standard-deviation-comparison-sheets-in-Sphere-SphereSDDR branch July 4, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants