-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contribution tracking for sddr materials #308
Merged
alexvalentine94
merged 26 commits into
developing
from
add-contribution-tracking-for-SDDR-materials
Sep 27, 2024
Merged
Add contribution tracking for sddr materials #308
alexvalentine94
merged 26 commits into
developing
from
add-contribution-tracking-for-SDDR-materials
Sep 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me. The additions have also been well tested with the implementation of new tests. I just want to check are still happy with the minimal version of F4Enix that can be supported since it has been some time since the PR was submitted.
alexvalentine94
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should be reviewed after PR #300 and PR #306
This PR adds the tracking of the contribution to the SDDR tally of the different parents to the typical materials assessed in the SphereSDDR benchmark. The implementation is similar to what has been done for the FNG SDDR benchmark.
Type of change
Please select what type of change this is.
Other changes
Testing
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Some additional tests have been added to the CI suite and the feature has also been tested in a production case.
Checklist: