Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contribution tracking for sddr materials #308

Merged

Conversation

dodu94
Copy link
Member

@dodu94 dodu94 commented Jul 15, 2024

Description

Should be reviewed after PR #300 and PR #306

This PR adds the tracking of the contribution to the SDDR tally of the different parents to the typical materials assessed in the SphereSDDR benchmark. The implementation is similar to what has been done for the FNG SDDR benchmark.

Type of change

Please select what type of change this is.

  • Bug fix (non-breaking change which fixes an issue)
  • New benchmark
    • Non-breaking change which entirely uses exisiting classes, structure etc
    • Breaking change which has implemented new/modified classes etc
  • New feature
    • Non-breaking change which adds functionality
    • Breaking change fix or feature that would cause existing functionality to not work as expected

Other changes

  • This change requires a documentation update
  • (If Benchmark) This requires additional data that can be obtained from:
    • Benchmark data 1
    • Benchamrk data 2

Testing

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Some additional tests have been added to the CI suite and the feature has also been tested in a production case.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • General testing
    • New and existing unit tests pass locally with my changes
    • Coverage is >80%

@dodu94 dodu94 marked this pull request as ready for review July 15, 2024 08:28
@dodu94 dodu94 requested a review from alexvalentine94 July 15, 2024 08:28
@dodu94 dodu94 requested a review from sbradnam September 13, 2024 15:38
Copy link
Collaborator

@alexvalentine94 alexvalentine94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. The additions have also been well tested with the implementation of new tests. I just want to check are still happy with the minimal version of F4Enix that can be supported since it has been some time since the PR was submitted.

@alexvalentine94 alexvalentine94 merged commit cddfb9c into developing Sep 27, 2024
8 checks passed
@dodu94 dodu94 deleted the add-contribution-tracking-for-SDDR-materials branch November 6, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants