-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yaml config files #355
Yaml config files #355
Conversation
Codecov ReportAttention: Patch coverage is
... and 1 file with indirect coverage changes 🚨 Try these New Features:
|
|
||
# Example of an extract from a benchmark configuration file, Excel section | ||
Excel: | ||
4.0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some cases the tally number is a float, other cases just an integer. Minor, I guess just by product of conversion script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct, I kept both to be sure that it works in both cases just to be sure
identifier: 244 | ||
plot_type: Ratio graph | ||
quantity: Photon Flux | ||
unit: '#/cc/n_s' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some units contained in apostrophes, others not. Reflected in the output?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I double checked, they are both read as string independently of the use of quotes fortunately
11: | ||
identifier: 11 | ||
plot_type: Grouped bars | ||
quantity: 'Neutron current ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some quantities (Neutron current) are in quotes. Others note. Reflected in ouput?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I double checked, they are both read as string independently of the use of quotes fortunately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Davide, a nice enhancement. Happy to approve, outstanding comments minor and looks to me not be impactful. Leave to you to merge if happy.
Description
TO BE REVIEWED AFTER MERGE OF #333
This PR implements a change in the configuration files for computational benchmarks which will now be in .yaml format instead of .xlsx. Eventually, all configuration files should move to either .yaml of .toml format as .xlsx are not correctly tracked by git.
The legacy behaviour is mantained for all non-computational benchmarks.
Additional dependencies introduced.
pyyaml
Type of change
Please select what type of change this is.
Other changes
Testing
Suitable tests have been added to the CI suite.
Checklist: