Apply patch for [email protected] with gcc10: and *mpich*

[climbfuji]

Description

See NOAA-GFDL/FMS#1417. This is needed to build [email protected] on Derecho with gcc@12 and cray-mpich. I had to make this modification manually when rolling out spack-stack-1.5.1 and then forgot to submit the bug fix. Tested on Derecho, and the FMS team also tested this on their systems. See NOAA-GFDL/FMS#1418.

Issue(s) addressed

n/a

Dependencies

n/a

Impact

Expected impact on downstream repositories: n/a

Checklist

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have run the unit tests before creating the PR

[ulmononian]

thank you for this, @climbfuji!

[climbfuji]

I see that the macos unit tests are now failing with an error that tar is not found:

FAILED lib/spack/spack/test/cmd/reindex.py::test_reindex_basic[mock_archive0] - spack.build_environment.ChildError: CommandNotFoundError: spack requires 'tar'. Make sure it is in your path.
FAILED lib/spack/spack/test/cmd/reindex.py::test_reindex_db_deleted[mock_archive0] - spack.build_environment.ChildError: CommandNotFoundError: spack requires 'tar'. Make sure it is in your path.
FAILED lib/spack/spack/test/cmd/reindex.py::test_reindex_with_deprecated_packages[mock_archive0] - spack.build_environment.ChildError: CommandNotFoundError: spack requires 'tar'. Make sure it is in your path.
!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 4 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!

This has nothing to do with the PR, I assume that something has changed in the macOS github runner as it did in the past.