Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required Billing Fields #3

Open
embedded1 opened this issue Mar 3, 2015 · 6 comments
Open

Required Billing Fields #3

embedded1 opened this issue Mar 3, 2015 · 6 comments

Comments

@embedded1
Copy link

I'm using your library for validating orders processed via PayPal and therefore I don't have any billing information.

I've talked to MaxMind and they told me I can continue without the billing data.
Why did you mark the billing as required fields?

Can you please mark the billing fields as not required and push an update?

@JDBurnZ
Copy link
Owner

JDBurnZ commented Mar 3, 2015

Good catch, I was with the understanding this was a required field. I'll review and update as appropriate.

@embedded1
Copy link
Author

thanks for your fast reply.
I will update and verify that your fix works.

On Tue, Mar 3, 2015 at 9:13 PM, Joshua D. Burns [email protected]
wrote:

Good catch, I was with the understanding this was a required field. I'll
review and update as appropriate.


Reply to this email directly or view it on GitHub
#3 (comment).

@JDBurnZ
Copy link
Owner

JDBurnZ commented Mar 3, 2015

Fixed, change was made in pyminfraud/fields.py.

@embedded1
Copy link
Author

did you update git?
why don't you support pip?

On Tue, Mar 3, 2015 at 9:19 PM, Joshua D. Burns [email protected]
wrote:

Fixed, change was made in pyminfraud/fields.py.


Reply to this email directly or view it on GitHub
#3 (comment).

@JDBurnZ
Copy link
Owner

JDBurnZ commented Mar 3, 2015

Yes, updated in Git.
I thought I had support for pip working at one time, but I see it's broken now.. I'll re-visit when I get a chance.

@embedded1
Copy link
Author

thanks, just updated, will keep you posted

On Tue, Mar 3, 2015 at 9:37 PM, Joshua D. Burns [email protected]
wrote:

Yes, updated in Git.
I thought I had support for pip working at one time, but I see it's broken
now.. I'll re-visit when I get a chance.


Reply to this email directly or view it on GitHub
#3 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants