Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/frontend mvp #11

Merged
merged 4 commits into from
Jul 12, 2021
Merged

Feature/frontend mvp #11

merged 4 commits into from
Jul 12, 2021

Conversation

tomwalsh96
Copy link
Collaborator

Realtime page layout for react app, not yet connected to bus routes data

Changes

I have included a google maps component, and made the layout responsive for mobile devices

Checklist:

  • Tests
    I have yet to implement any tests, the code is still not finalised as I have not connected to the real graphql bus data

  • Documentation
    Again, no finalised documentation needs to be added as the page is not finished

How to use

The UI is self-explanatory. Dropdown menus can be seen on one side of the page, and a map component on the other. I created a custom popup component for the map, which will contain relevant stop information.

I was working to achieve the following design:
realtime-design

A gif of the completed page in action can be seen below:
realtime_page_smallerfile

In order to run the code, a .env file must be created in the /web_app directory, with a google maps API key. Include one line in this file in the following format:
REACT_APP_GOOGLE_API_KEY={key}

How the design has changed compared to mockups

  • an additional dropdown search was added (it is just a duplicate for now, and still dummy data)
  • a google maps component was added
  • a map popup was added
  • the page was made responsive, when the width of the viewport gets below a certain point the layout collapses into a mobile view

Additional notes

This is still a work in progress. I need to merge this code into the main branch in order to connect to the new graphql bus routes data.

- false positives being alerted on npm audit
- fixed by moving reacts-scriptsto devDependencies as per; facebook/create-react-app#11102
- Includes Initial unstyled Marker and Popup
@tomwalsh96 tomwalsh96 requested a review from JFfarrell July 12, 2021 10:09
@tomwalsh96 tomwalsh96 self-assigned this Jul 12, 2021
@JasonBallantyne
Copy link
Collaborator

Looks ideal, good job!

.gitignore Outdated Show resolved Hide resolved
@JFfarrell
Copy link
Owner

LGTM! if you send me your .env file, I can test it locally

@tomwalsh96 tomwalsh96 merged commit c205495 into main Jul 12, 2021
@tomwalsh96 tomwalsh96 deleted the feature/frontend-mvp branch July 12, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants