[FIX] MainApiGlobalExceptionHandler에 @Slf4j 어노테이션 추가 #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlajm1203
commented
Jan 17, 2025
| @@ -14,6 +15,7 @@ | |||
|
|
|||
| @RestControllerAdvice | |||
| @RequiredArgsConstructor | |||
| @Slf4j | |||
| public class MainApiGlobalExceptionHandler { | |||
| //TODO: mapper | |||
| @ExceptionHandler(ApplicationException.class) | |||
There was a problem hiding this comment.
@slf4j 어노테이션을 통해 로깅을 사용할 수 있게 되었습니다. 이로써 어떤 예외가 발생했는지 등의 정보를 로그에 남길 수 있게 되었습니다. 이외에도 예외 처리를 위해 @ExceptionHandler 어노테이션이 사용되었는데, ApplicationException이라는 예외가 발생했을 때 처리할 코드를 추가해 주셨습니다. 현재로서는 큰 문제가 없어 보입니다. 단, mapper에 대한 TODO 주석이 있어 해당 부분에 대한 구현이 필요한 것으로 보입니다. 해당 구현을 빠르게 완료하여 기능을 완성하는 것이 중요해 보입니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✨ PR 내용
🤓 리뷰어에게