Introduce CLI frontend rewrite based on Click #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Main command name `dsc` for now... - Store in separate package named discodos.cmd23. - One module for each subcommand.
args_helper.User_int class, since discodos.ctrl classes expect to receive a positional argument named user.
and create the context object to be passed to subcommands - our reimplemented helper.User class.
- User interaction helper is passed as arg "helper" via a context object.
- A local function update_user_interaction_helper sets user.WANTS... attributes
- Previsouly we passed all the argparser args at once and everything
happenend when the User_int object was initialized.
- Now with Click, updating the user object must be split. Each subcommand
sets the attrs it is responsible for.
- Logger. - Empty update_user_insteraction_helper() function.
in ctrls.py in offline search method when only one single release is found (.repro by passing an ID instead of searchterm)
- Formatting of @options for code readability. - Fix import_id arg passing.
JOJ0
added a commit
that referenced
this pull request
Oct 29, 2024
Introduce CLI frontend rewrite based on Click
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dscand might be renamed later.discois still available for reference.discoalready.Issues: