Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to filter out empty rooms in room list #48

Closed
JOJ0 opened this issue Dec 1, 2021 · 3 comments
Closed

Add an option to filter out empty rooms in room list #48

JOJ0 opened this issue Dec 1, 2021 · 3 comments
Assignees
Labels
feature Feature request, not a core feature

Comments

@JOJ0
Copy link
Owner

JOJ0 commented Dec 1, 2021

as discussed in #synadm:peek-a-boo.at (specific message)

To be decicded:

  • Should it really be an option in synadm room list that just shows empty rooms and purging has to be done using jq/shell magic/looping and invoking synadm room delete?
  • or rather be a separate command named something like synadm room purge-empty (similar to synadm user prune-devices
  • Or even both?
@erdnaxeli
Copy link

I am for the synadm room purge-empty 👍

@JOJ0
Copy link
Owner Author

JOJ0 commented Dec 8, 2021

Hi @erdnaxeli, thanks for the vote! Yes I like the separate purge/prune command as well and will implement it. Nonetheless I had started already to implement a --empty flag to the room list command. It turned out that it it's not as straight forward as I thought due the pagination features. I kind of solved it but rather ugly, quick and dirty. This is the feature draft for now but I am not really happy with it. If you have a minute, give it a try on your server: https://github.com/JOJ0/synadm/tree/room_empty
I would welcome any input on how to proceed with this.

@JOJ0 JOJ0 added the feature Feature request, not a core feature label Feb 24, 2022
JacksonChen666 added a commit to JacksonChen666/synadm that referenced this issue Apr 2, 2024
@JacksonChen666 JacksonChen666 self-assigned this Apr 2, 2024
JacksonChen666 added a commit to JacksonChen666/synadm that referenced this issue Apr 3, 2024
fetches whole room list first until we're out of empty rooms

Closes: JOJ0#48
@JacksonChen666
Copy link
Collaborator

synadm room purge-empty was implemented in 48fa5de.

synadm room list --empty was not implemented because that had shortcomings (needing the right sorting arguments, plus room listing is technically already implemented via synadm room purge-empty).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request, not a core feature
Projects
None yet
Development

No branches or pull requests

3 participants