Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline notice send --batch-size option #104

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Streamline notice send --batch-size option #104

merged 1 commit into from
Mar 10, 2023

Conversation

JOJ0
Copy link
Owner

@JOJ0 JOJ0 commented Mar 9, 2023

  • Add it as the first option so the variables in code is now named batch_size and adapt code accordingly.
  • Keep paginate as an alternative option.
  • Change helptext just slightly.

@JOJ0
Streamline notice send --batch-size option
e522d92 
- Add it as the first option so the variables in code is now named
  batch_size and adapt code accordingly.
- Keep paginate as an alternative option.
- Change helptext just slightly.
@JOJ0 JOJ0 requested a review from JacksonChen666 March 9, 2023 16:40
JacksonChen666
JacksonChen666 approved these changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@JacksonChen666 JacksonChen666 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me (tangent sidenote: i think the batch size might not be applying because of line 138 or something else, only found 8 user list requests when it should've been 35 when batch size was 20 with 699 accounts)

@JOJ0
Copy link
Owner Author

JOJ0 commented Mar 10, 2023

Let's merge this as is and remember that this feature definitely needs verification and potential fixing! Nice catch!

@JOJ0 JOJ0 merged commit 738b4e4 into master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacksonChen666 JacksonChen666 JacksonChen666 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JOJ0 @JacksonChen666