Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement user (un)locking #125

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

JacksonChen666
Copy link
Collaborator

fixes #121

did not go with synadm user lock, since it seemed like it was gonna be extra work (due to modify api being one big monolithic thing for many things) and just adding on to synadm user modify was actually easier.

@JacksonChen666 JacksonChen666 requested a review from JOJ0 September 3, 2023 11:34
Copy link
Owner

@JOJ0 JOJ0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on my prod server with a Synapse version that didn't have this admin-api-feature yet: It tries to set locking but it gets ignored without throwing an error. Also the "current settings" does not include locked: yet (we pull that via synadm user details.

I updated my Synapse to latest, now I see locked: false in the "current settings" list, and it can be successfully locked and unlocked.

LGTM, merge it please! :-)

@JacksonChen666
Copy link
Collaborator Author

i was going to add onto the PR with other commands that may not get the locked details, but the problem is i can't get a development synapse running right now i just resolved it :P

@JacksonChen666 JacksonChen666 merged commit 5521cdd into JOJ0:master Sep 4, 2023
@ser
Copy link

ser commented Sep 5, 2023

Thank you very much! Appreciate.

@ser
Copy link

ser commented Sep 8, 2023

So maybe it's worth of new release? :)

@JacksonChen666
Copy link
Collaborator Author

So maybe it's worth of new release? :)

yes, one will come very soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account (un)locking
3 participants