eclipse-che#4306 fix NPE in case of invalid java FQN (eclipse-che#4654)

Signed-off-by: Even Vidolob <[email protected]>
JPinkney · Mar 31, 2017 · 2fbe5a4 · 2fbe5a4
1 parent 9a29efa
commit 2fbe5a4
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/...lang-server/src/main/java/org/eclipse/che/plugin/java/server/rest/RefactoringService.java b/...lang-server/src/main/java/org/eclipse/che/plugin/java/server/rest/RefactoringService.java
@@ -36,6 +36,7 @@
 import org.eclipse.jdt.core.ICompilationUnit;
 import org.eclipse.jdt.core.IJavaElement;
 import org.eclipse.jdt.core.IJavaProject;
+import org.eclipse.jdt.core.IType;
 import org.eclipse.jdt.core.JavaModelException;
 import org.eclipse.jdt.internal.core.JavaModel;
 import org.eclipse.jdt.internal.core.JavaModelManager;
@@ -89,7 +90,14 @@ public String createMoveRefactoring(CreateMoveRefactoring cmr) throws JavaModelE
                     if (javaElement.isPack()) {
                         return javaProject.findPackageFragment(new org.eclipse.core.runtime.Path(javaElement.getPath()));
                     } else {
-                        return javaProject.findType(javaElement.getPath()).getCompilationUnit();
+
+                        IType type = javaProject.findType(javaElement.getPath());
+
+                        //in some cases client may send FQN that doesn't exist
+                        if (type == null) {
+                            throw new IllegalArgumentException("Can't find type: " + javaElement.getPath());
+                        }
+                        return type.getCompilationUnit();
 
                     }
                 } catch (JavaModelException e) {