Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored function names in R/summarize.R #67

Closed

Conversation

teddyCodex
Copy link
Collaborator

Description

Refactored specified function names in R/summarize.R based on issue #7

Original Modified User Facing
filter_by_doms filterByDomains  ✅
count_bycol countByColumn  ✅
elements2words elements2Words  
find_paralogs findParalogs  ✅
words2wc words2WordCounts  
filter_freq filterByFrequency  ✅
summarize_bylin summarizeByLineage  ✅
summ.DA.byLin summarizeDomArch_ByLineage  ✅
summ.DA summarizeDomArch  ✅
summ.GC.byDALin summarizeGenContext_ByDomArchLineage  ✅
summ.GC.byLin summarizeGenContext_ByLineage  ✅
summ.GC summarizeGenContext  ✅
total_counts totalGenContextOrDomArchCounts

Fixes issue #53

What kind of change(s) are included?

  • Feature (adds or updates new capabilities)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • I have added comments to my code to help provide understanding.
  • I have added a test which covers the code changes found within this PR.
  • I have deleted all non-relevant text in this pull request template.
  • Reviewer assignment: Tag a relevant team member to review and approve the changes.

@teddyCodex
Copy link
Collaborator Author

teddyCodex commented Oct 7, 2024

@jananiravi @the-mayer file containing other locations where the functions are called or referenced.

function_occurrences #53.txt

@Joiejoie1 Joiejoie1 mentioned this pull request Oct 7, 2024
3 tasks
@teddyCodex teddyCodex closed this Oct 8, 2024
@teddyCodex teddyCodex force-pushed the issue-53-rename-functions branch from 7684306 to 94369a2 Compare October 8, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant