Disabling the "strict-type-predicates" rule until this TSLint bug is f…

…ixed: palantir/tslint#4107
JS-DevTools · Dec 1, 2018 · 0cb228d · 0cb228d
1 parent 91466f5
commit 0cb228d
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/_ts/github/github.ts b/_ts/github/github.ts
@@ -21,7 +21,6 @@ export class GitHub {
     const url = `https://api.github.com/users/${account.login}`;
 
     return this._gitHubApiRequest(url, (response) => {
-      // tslint:disable-next-line:strict-type-predicates
       if (typeof response.rawBody !== "object") {
         throw new ApiError(url, "did not return a JSON object as expected", response.rawBody);
       }

diff --git a/_ts/state-store/cache.ts b/_ts/state-store/cache.ts
@@ -115,8 +115,6 @@ function setItem(key: string, value: POJO): void {
  * Deserializes date strings when parsing JSON
  */
 function reviver(key: string, value: unknown): unknown {
-  // TSLint Bug - https://github.com/palantir/tslint/issues/4107
-  // tslint:disable-next-line:strict-type-predicates
   if (typeof value === "string" && jsonDatePattern.test(value)) {
     value = new Date(value);
   }

diff --git a/_ts/util.ts b/_ts/util.ts
@@ -22,7 +22,6 @@ export interface JsonPOJO extends POJOof<string | number | boolean | JsonPOJO |
  * Returns the given value as a pretty-formatted string
  */
 export function prettify(value: unknown): string {
-  // tslint:disable-next-line:strict-type-predicates
   if (value && typeof value === "object") {
     return JSON.stringify(value, undefined, 2);
   }

diff --git a/tslint.yaml b/tslint.yaml
@@ -168,6 +168,10 @@ rules:
   # Allow boolean expressions to use any truthy/falsy value, not just boolean
   strict-boolean-expressions: false
 
+  # Disabling this rule until this TSLint bug is fixed:
+  # https://github.com/palantir/tslint/issues/4107
+  strict-type-predicates: false
+
   # Don't require a default for every switch statement
   switch-default: false