Ensure consistent buffer size for snprintf (#1035)

JSBSim-Team · Feb 6, 2024 · d2d8f61 · d2d8f61
1 parent 0176553
commit d2d8f61
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/simgear/props/props.cxx b/src/simgear/props/props.cxx
@@ -1570,7 +1570,7 @@ SGPropertyNode::setIntValue (int value)
   case props::STRING:
   case props::UNSPECIFIED: {
     char buf[128];
-    snprintf(buf, 128, "%d", value);
+    snprintf(buf, sizeof(buf), "%d", value);
     result = set_string(buf);
     break;
   }
@@ -1621,7 +1621,7 @@ SGPropertyNode::setLongValue (long value)
   case props::STRING:
   case props::UNSPECIFIED: {
     char buf[128];
-    snprintf(buf, 128, "%ld", value);
+    snprintf(buf, sizeof(buf), "%ld", value);
     result = set_string(buf);
     break;
   }
@@ -1672,7 +1672,7 @@ SGPropertyNode::setFloatValue (float value)
   case props::STRING:
   case props::UNSPECIFIED: {
     char buf[128];
-    snprintf(buf, 128, "%f", value);
+    snprintf(buf, sizeof(buf), "%f", value);
     result = set_string(buf);
     break;
   }
@@ -1723,7 +1723,7 @@ SGPropertyNode::setDoubleValue (double value)
   case props::STRING:
   case props::UNSPECIFIED: {
     char buf[128];
-    snprintf(buf, 128, "%f", value);
+    snprintf(buf, sizeof(buf), "%f", value);
     result = set_string(buf);
     break;
   }

diff --git a/src/utilities/prep_plot.cpp b/src/utilities/prep_plot.cpp
@@ -177,7 +177,7 @@ int main(int argc, char **argv)
     nokey = true;
     while (1) {
       new_filename=filename;
-      sprintf(num,"%d",file_ctr);
+      snprintf(num,sizeof(num),"%d",file_ctr);
       new_filename.replace(new_filename.find("#"),1,num);
       infile2.open(new_filename.c_str());
       if (!infile2.is_open()) {

diff --git a/utils/aeromatic++/Aircraft.cpp b/utils/aeromatic++/Aircraft.cpp
@@ -95,7 +95,7 @@ Aircraft::get_verbose_description(int no_engines)
         if (no_engines < 0) rv += ')';
     }
 
-    snprintf(desc, 1024, "%s", rv.c_str());
+    snprintf(desc, sizeof(desc), "%s", rv.c_str());
     return desc;
 }