-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add geodetic altitude to CSV log #190
Conversation
Just realized I wasn't running all of the tests locally.. I can reproduce this now and will look into it. |
daeb31c
to
efdc1ef
Compare
Ok, here is a new attempt. The failure of test case
It's a bit hard to see in a textual diff, but what this accomplishes is that all values of the old logfile are exactly preseverd, such that...
... outputs I also found some comments listing the log columns, so I updated those. The last commit still includes all changes to remove one of the duplicate altitude/distance AGL columns. May be omitted, if it's not desired to remove that column. |
hmm, the failures on Travis CI, I cannot reproduce reliably with my local setup. Although I have seen the segfault in |
You can get the same result when the property <output name="result.csv" type="CSV" rate="10">
<property> position/geod-alt-ft </property>
</output> So there is no reason to add C++ code to get that value (and that saves the trouble about the file |
Ok, thank's for the help. I didn't know that one could specify additional properties, so that's good to know. For what it's worth, I still think removing the duplicate distance/altitude AGL would be an improvement to the C++ code, but probably not worth the trouble. Closing this now, as it's not required to be merged anymore. |
Hi,
I would like to have the geodetic altitude added to the CSV log. Besides my personal use cases, this may be helpful for future work on issue #184. Also, it'll simply make the log more complete.
I noticed, that the altitude AGL / distance above ground is currently being logged twice. I removed one of the entries in the second commit, because I think there shouldn't be any redundant data in the output file. If this shall be kept for backwards-compatibility, just omit the 2nd commit.